Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the lib directory from source control; add types meta #16

Merged

Conversation

marcusrbrown
Copy link
Contributor

I noticed some older source files in the lib folder. This change will remove those files from source control. I also added the types field to package.json as a hint to software that looks for type declarations (VS Code, online REPLs, etc.).

@thejustinwalsh
Copy link
Member

thejustinwalsh commented Jan 28, 2022

Just to make sure I follow, the idea here is that lib is only needed in the final package sent to npm and is generated currently via publish.

Maybe there should also be a prepare / prepublishOnly script that calls build to ensure bad packages do not make it out to npm? Slightly outside the scope of this change and can be done in a follow up: #18.

@thejustinwalsh thejustinwalsh merged commit 250642f into ts-defold:main Jan 28, 2022
@marcusrbrown marcusrbrown deleted the feat/remove-lib-from-scm branch January 28, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants