Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix watch mode #198

Merged
merged 1 commit into from Jun 22, 2022
Merged

chore: fix watch mode #198

merged 1 commit into from Jun 22, 2022

Conversation

mikearnaldi
Copy link
Member

@mikearnaldi mikearnaldi commented Jun 22, 2022

First step of having incremental and watch mode working fine, at the moment I treat every file that contains any ts+ definition like a global file referenced by any other file.

This while it should work it may be triggering too much recompilation, a better approach would be better to track in the checker which files extends what and only track imported scope, basically:

1: each file is processed in init, we detect A extends B if A has an extension declared in B
2: when adding referenced files we add 1 global imports (maybe used) and 2 (directly referenced imports(

@mikearnaldi mikearnaldi requested a review from 0x706b Jun 22, 2022
@mikearnaldi mikearnaldi merged commit ca775d4 into main Jun 22, 2022
1 check was pending
@mikearnaldi mikearnaldi deleted the fix/watch-mode-tracking-refs branch Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant