Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable nested routers by introducing RecursivelyProcessAppRouter #138

Merged
merged 3 commits into from Jan 22, 2023

Conversation

oliverbutler
Copy link
Collaborator

Fixes #47 (finally!!!)
Screenshot 2023-01-22 at 23 15 10

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2023

🦋 Changeset detected

Latest commit: e04f43f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@ts-rest/core Minor
@ts-rest/example-contracts Minor
@ts-rest/express Minor
@ts-rest/nest Minor
@ts-rest/next Minor
@ts-rest/open-api Minor
@ts-rest/react-query Minor
@ts-rest/solid-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ts-rest ✅ Ready (Inspect) Visit Preview Jan 22, 2023 at 11:15PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #138 (e04f43f) into main (ec4a10e) will decrease coverage by 19.10%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##             main     #138       +/-   ##
===========================================
- Coverage   84.57%   65.47%   -19.10%     
===========================================
  Files           9        9               
  Lines         188      252       +64     
  Branches       44       60       +16     
===========================================
+ Hits          159      165        +6     
- Misses         19       77       +58     
  Partials       10       10               
Impacted Files Coverage Δ
libs/ts-rest/core/src/lib/dsl.ts 70.00% <ø> (ø)
libs/ts-rest/express/src/lib/ts-rest-express.ts 13.23% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Gabrola Gabrola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🔥

@oliverbutler oliverbutler merged commit 13ca71b into main Jan 22, 2023
@michaelangeloio
Copy link
Contributor

amazing work!

@Gabrola Gabrola deleted the feature/utilise-satifies-to-fix-nested-contracts branch February 3, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create nested contract router with loosing path narrowing
4 participants