The rsm command was failing with an AttributeError. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proximate cause is that if config is read from a file (and the confih parameter is None) then the config reference never gets initialized sensibly. To fix, we replace all references to config with config_instance. (It might have been simpler to assign config_instance to config, but this seems unclean). Signed-off-by: Jon Seymour <jon.seymour@wildducktheories.com>
|
Closed. To re-open as PR against develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proximate cause is that if config is read from a file (and the confih parameter is None)
then the config reference never gets initialized sensibly.
To fix, we replace all references to config with config_instance.
(It might have been simpler to assign config_instance to config, but
this seems unclean).
Signed-off-by: Jon Seymour jon@wildducktheories.com