Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE packet bandwidth #116

Closed
italobusi opened this issue Dec 28, 2020 · 4 comments
Closed

TE packet bandwidth #116

italobusi opened this issue Dec 28, 2020 · 4 comments

Comments

@italobusi
Copy link
Collaborator

TE packet bandwidth augmentations in ietf-te-mpls-topology can be moved to te-topology-packet since they are not specific for MPLS but also applicable to other packet technologies (e.g., ETH).

@italobusi
Copy link
Collaborator Author

italobusi commented Dec 28, 2020

2020-12-18 TEAS Call

Discussion about how to represent TE packet bandwidth (in Mbps, Gbps)

Option 1:

cir
  bandwidth uint64
  unit      enum

Option 2:

cir string (with a pattern)

Option 3:

(unit)
  (kbps)
    cir-kbps
  (mbps)
    cir-mbps
  (gbps)
    cir-gbps

Agreement for Option 2

@tsaad-dev : propose the pattern
@xufengliu : check if XPath allows comparison in case the string is using scientific notation

A pattern using scientific notation seems preferable to enable comparisons, as per https://tools.ietf.org/html/rfc7950#section-6.4:

  • 10k -> 10e3
  • 10m -> 10e6
  • 1100 -> 1.1e3

@italobusi
Copy link
Collaborator Author

A pattern using scientific notation seems preferable to enable comparisons, as per https://tools.ietf.org/html/rfc7950#section-6.4:

https://tools.ietf.org/html/rfc7950#section-6.4 references IEEE 754 which is "IEEE Standard for Binary Floating-Point Arithmetic".

I am not sure this definition actually supports scientific notation.

@tsaad-dev
Copy link
Owner

Sample type:
typedef bw-string {
pattern "[0-9].[e-E][0-9]."
}

Sample leaf:
leaf bw {
type bw-string;
}

italobusi added a commit to italobusi/te that referenced this issue Jul 11, 2021
Added bandwidth-scientific-notation types as per discussion in tsaad-dev#116
italobusi added a commit that referenced this issue Jul 12, 2021
Move common packet types from MPLS-TE type to Packet TE types (updating RFC8776)

Added bandwidth-scientific-notation types as per discussion in #116

Move TE packet bandwidth augmentations from MPLS-TE Topology to Packet TE Topology

Uploaded draft (md, txt and xml) for the MPLS-TE Topology model (draft-busizheng-teas-yang-te-mpls-topology-01)
@italobusi
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants