fix argument type and remove the quotes, so it can be recognized by t…

…he database. #5
tsahi · Jul 7, 2020 · 4e5f0d1 · 4e5f0d1
1 parent f59876d
commit 4e5f0d1
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 9 deletions.
diff --git a/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/CustOrdersOrders.prc b/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/CustOrdersOrders.prc
@@ -1,10 +1,14 @@
-CREATE OR REPLACE PROCEDURE "CustOrdersOrders"(VCUSTOMERID IN Orders.OrderID%TYPE := 1, CUR_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
+CREATE OR REPLACE PROCEDURE CustOrdersOrders(VCUSTOMERID IN Orders.CustomerID%TYPE := 1, CUR_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
 	AS
 
 BEGIN
     OPEN cur_OUT FOR
-	SELECT *
+	SELECT
+		OrderID,
+		OrderDate,
+		RequiredDate,
+		ShippedDate
 	FROM Orders
-	WHERE customerID = vCustomerId;
+	WHERE CustomerID = vCustomerId;
 END;
 /
diff --git a/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERBYID.prc b/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERBYID.prc
@@ -1,4 +1,4 @@
-CREATE OR REPLACE PROCEDURE "GETCUSTOMERBYID" ( vCustomerId IN Customers.CustomerID%TYPE := 1, cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
+CREATE OR REPLACE PROCEDURE GETCUSTOMERBYID( vCustomerId IN Customers.CustomerID%TYPE := 1, cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
 	AS
 
 BEGIN

diff --git a/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMEROUT.prc b/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMEROUT.prc
@@ -1,4 +1,4 @@
-CREATE OR REPLACE PROCEDURE "GETCUSTOMEROUT" ( vCustomerId IN Customers.CustomerID%TYPE, vName OUT Customers.COMPANYNAME%TYPE,cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
+CREATE OR REPLACE PROCEDURE GETCUSTOMEROUT( vCustomerId IN Customers.CustomerID%TYPE, vName OUT Customers.COMPANYNAME%TYPE,cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
 	AS
 
 BEGIN

diff --git a/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERSANDPRODUCTSVIEW.prc b/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERSANDPRODUCTSVIEW.prc
@@ -1,4 +1,4 @@
-CREATE OR REPLACE PROCEDURE "GETCUSTOMERSANDPRODUCTSVIEW" (cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE,cur_Products OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
+CREATE OR REPLACE PROCEDURE GETCUSTOMERSANDPRODUCTSVIEW(cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE,cur_Products OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
 	AS
 
 BEGIN

diff --git a/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERSVIEW.prc b/BVT/Data.BVT/DatabaseSetupScripts/OracleDBScripts/3.SP/GETCUSTOMERSVIEW.prc
@@ -1,4 +1,4 @@
-CREATE OR REPLACE PROCEDURE "GETCUSTOMERSVIEW" ( cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
+CREATE OR REPLACE PROCEDURE GETCUSTOMERSVIEW( cur_OUT OUT PKGENTLIB_ARCHITECTURE.CURENTLIB_ARCHITECTURE)
 	AS
 
 BEGIN

diff --git a/source/Tests/Oracle.Tests.VSTS/OracleParameterDiscoveryFixture.cs b/source/Tests/Oracle.Tests.VSTS/OracleParameterDiscoveryFixture.cs
@@ -79,14 +79,13 @@ public void IsCacheUsed()
         }
 
         [TestMethod]
-        [Ignore]
         public void CanDiscoverFeaturesWhileInsideTransaction()
         {
             using (DbConnection connection = db.CreateConnection())
             {
                 connection.Open();
                 DbTransaction transaction = connection.BeginTransaction();
-                DbCommand storedProcedure = db.GetStoredProcCommand("CustOrdersOrders"); //there is no such sproc
+                DbCommand storedProcedure = db.GetStoredProcCommand("CustOrdersOrders");
                 storedProcedure.Connection = transaction.Connection;
                 storedProcedure.Transaction = transaction;