Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for Argument mappings #419

Closed
pouryafard75 opened this issue Mar 23, 2023 · 1 comment
Closed

Improvement for Argument mappings #419

pouryafard75 opened this issue Mar 23, 2023 · 1 comment

Comments

@pouryafard75
Copy link
Contributor

facebook/buck@a1525ac
File: DebugPathSanitizer.java

Problem: workingDir.get() was passed as the argument in Line 107 child version return getAllPathsWork(workingDir.get());
image

Screenshot 2023-03-22 at 10 40 15 PM
@pouryafard75 pouryafard75 mentioned this issue Mar 23, 2023
Closed
@pouryafard75 pouryafard75 changed the title Improvement for Parameter to Argument mapping Improvement for Argument mappings Mar 23, 2023
tsantalis added a commit that referenced this issue Mar 23, 2023
@tsantalis
Fix for issue #419
7231881
@tsantalis
Copy link
Owner

@pouryafard75

Please re-run all tests you have involving argument mappings.

Screenshot from 2023-03-23 15-15-59

@pouryafard75 pouryafard75 mentioned this issue Mar 23, 2023
Closed
2 tasks
tsantalis added a commit that referenced this issue Mar 23, 2023
@tsantalis
Revert "Fix for issue #419"
9b00d06 
This reverts commit 7231881.
@tsantalis tsantalis reopened this Mar 23, 2023
tsantalis added a commit that referenced this issue Mar 23, 2023
@tsantalis
Final fix for issue #419
720712f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsantalis @pouryafard75