-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing files in ASTDiff view #752
Comments
@tsantalis class org.eclipse.jdt.core.dom.TypeDeclaration cannot be cast to class org.eclipse.jdt.core.dom.RecordDeclaration (org.eclipse.jdt.core.dom.TypeDeclaration and org.eclipse.jdt.core.dom.RecordDeclaration are in unnamed module of loader 'app') |
@pouryafard75 else if(bodyDeclaration instanceof RecordDeclaration) {
RecordDeclaration recordDeclaration = (RecordDeclaration)abstractTypeDeclaration; |
@tsantalis |
@tsantalis |
@victorgveloso |
Brilliant! Is it possible to manually trigger the docker generation? |
@tsantalis has the permission to do so.
…On Fri, Jun 21, 2024 at 9:22 PM vgveloso ***@***.***> wrote:
Brilliant!
Is it possible to manually trigger the docker generation?
—
Reply to this email directly, view it on GitHub
<#752 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG34LRFV4J4HQROWRCSDUI3ZITGVXAVCNFSM6AAAAABJWKL4SGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBTGY2DIMRZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Please, @tsantalis reopen this issue. The solution seemed to work in the first place but now for some reason whenever I try to run
RMiner crashes with the following error message.
|
It looks like a bug accessing the GitHub API (based on the logged line But I failed to find the problem in that GitHub endpoint. By opening I get the expected output:
Similarly, the endpoint |
@victorgveloso |
Its strange because it worked properly two days ago when I took the screenshot! |
GitHub diff view:
ASTDiff view:
When analyzing the commit apache/logging-log4j2@c624e01 with the latest docker image, only two out of the three file diffs are displayed by ASTDiff.
Notice how ASTDiff completely misses the file BasicPropertyEnvironmentTest.java. Important disclaimer: both parent and child versions of the file are compilable!
This is not the only time I've seen this happening. Though it's the only time I considered reporting as the others were actually part of a Pull Request or their changes were mostly trivial.
In order to replicate this issue, just execute the following command in a machine with docker pre-installed:
docker run -P -d --rm -e OAuthToken=<YOUR_GITHUB_OAUTH_TOKEN> tsantalis/refactoringminer diff --url https://github.com/apache/logging-log4j2/commit/c624e01cc433cc36f23167c8f39ab40873ecc6ec
The text was updated successfully, but these errors were encountered: