completed games mvc #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions for each model, created the profile page, specified views for visitors/players/DM
houndci-bot
reviewed
Feb 1, 2017
spec/factories/users.rb
Outdated
| sequence(:username) { |n| 'testuser{n}' } | ||
| sequence(:email) { |n| 'test{n}@test.com' } | ||
| sequence(:username) { |n| 'testuser#{n}' } | ||
| sequence(:email) { |n| 'test#{n}@test.com' } |
There was a problem hiding this comment.
Unused block argument - n. You can omit the argument if you don't care about it.
houndci-bot
reviewed
Feb 1, 2017
spec/factories/users.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| FactoryGirl.define do | |||
| factory :user do | |||
| sequence(:username) { |n| 'testuser{n}' } | |||
| sequence(:email) { |n| 'test{n}@test.com' } | |||
| sequence(:username) { |n| 'testuser#{n}' } | |||
There was a problem hiding this comment.
Unused block argument - n. You can omit the argument if you don't care about it.
houndci-bot
reviewed
Feb 1, 2017
spec/factories/games.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| FactoryGirl.define do | |||
| factory :game do | |||
| sequence(:name) { |n| 'testgame{n}' } | |||
| sequence(:name) { |n| 'testgame#{n}' } | |||
There was a problem hiding this comment.
Unused block argument - n. You can omit the argument if you don't care about it.
houndci-bot
reviewed
Feb 1, 2017
| flash[:notice] = "#{@signup.user.username} has been added to #{@signup.game.name}" | ||
| redirect_to game_path(@game) | ||
| else | ||
| flash[:notice] = 'Error. Please make sure the username is spelled correctly, including capitalization' |
houndci-bot
reviewed
Feb 1, 2017
| @signup = Signup.create(user: @user, game: @game) | ||
| Request.where(user: @user, game: @game).delete_all | ||
| if @signup.save | ||
| flash[:notice] = "#{@signup.user.username} has been added to #{@signup.game.name}" |
houndci-bot
reviewed
Feb 1, 2017
| private | ||
|
|
||
| def comment_params | ||
| params.require(:comment).permit ( |
There was a problem hiding this comment.
Don't use parentheses around a literal.
houndci-bot
reviewed
Feb 1, 2017
| @@ -0,0 +1,25 @@ | |||
| class CommentsController < ApplicationController | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
houndci-bot
reviewed
Feb 1, 2017
| document.getElementById('div1').style.display='none'; | ||
| if (document.getElementById('writecomment') != null) { | ||
| document.getElementById('writecomment').style.display='block' | ||
| }; |
houndci-bot
reviewed
Feb 1, 2017
| function hidefield() { | ||
| document.getElementById('div1').style.display='none'; | ||
| if (document.getElementById('writecomment') != null) { | ||
| document.getElementById('writecomment').style.display='block' |
houndci-bot
reviewed
Feb 1, 2017
|
|
||
| function hidefield() { | ||
| document.getElementById('div1').style.display='none'; | ||
| if (document.getElementById('writecomment') != null) { |
houndci-bot
reviewed
Feb 1, 2017
| @@ -1,13 +1,17 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| describe GamesController, type: :controller do | |||
| include Devise::Test::ControllerHelpers | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added games views, buttons for all models, completed necessary CRUD actions for each model, created the profile page, specified views for visitors/players/DM