Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Camera360 #5

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Added Camera360 #5

merged 1 commit into from
Feb 27, 2021

Conversation

philjak
Copy link
Contributor

@philjak philjak commented Feb 26, 2021

Hey Thomas,

this should add Camera360 support. I'm not an expert in Python. When I tried:

device.privacymode(False) I got:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'State' object is not callable

But calling device._privacymode_service.put_state_element("value", "DISABLED") works perfectly, what seems to be what the privacymode-setter is doing. So I expect it was just my mistake using the command line correctly.

Hope everything is OK and you can merge it.

Thanks,
Philip

@philjak
Copy link
Contributor Author

philjak commented Feb 26, 2021

device.privacymode = False does the trick. Ok, I can confirm it's working.

session = boschshcpy.SHCSession(controller_ip="XXX", certificate='../client-cert.pem', key='../client-key.pem')
device = session.device('XXX')
device.privacymode = False

@tschamm tschamm merged commit 0e60a0d into tschamm:master Feb 27, 2021
@tschamm
Copy link
Owner

tschamm commented Feb 27, 2021

@philjak Looks fine for me. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants