Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nojekyll option to create .nojekyll file automatically #27

Closed
wants to merge 3 commits into from
Closed

Add nojekyll option to create .nojekyll file automatically #27

wants to merge 3 commits into from

Conversation

shinnn
Copy link

@shinnn shinnn commented Jan 5, 2014

How about nojekyll option?

When options.nojekyll is true, the gh-pages task will do:

  1. Check whether the src pattern includes one or more files or directories whose name start with _.
  2. If so, create .nojekyll file at the root of options.base dir and add .nojekyll to the src pattern.
  3. If not, remove the existing .nojekyll file at the root of options.base dir.

This option prevents us from forgetting to bypass Jekyll processing of Github Pages if it is unnecessary.

This PR adds the option described above and test for it.

@tschaub
Copy link
Owner

tschaub commented Feb 17, 2014

I appreciate your work on this, but I'm inclined not to add Jekyll specific behavior (though I know this plugin is named gh-pages and Jekyll is an integral part of GitHub's gh-pages handling). My justification is that I think it should be easy enough for users to create a .nojekyll file themselves (with a separate task). This plugin does quite a bit already, and I'd like to try to limit its scope.

@tschaub tschaub closed this Feb 17, 2014
@shinnn
Copy link
Author

shinnn commented Feb 17, 2014

I see.
Thanks you for reviewing my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants