Fixed grunt newer failing to restore configuration #80
Conversation
|
I've been diving into the grunt source code, and i think there may be a way to run a task and know when it finishes by using grunt.task directly. I would like to look into it then open this PR again once I know if there is a better way or not. |
|
the from the grunt command line help |
| grunt.registerTask("newer-force", function(set) { | ||
| if (set === "on") { | ||
| previous_force_state = grunt.option("force"); | ||
| grunt.option("force", true); |
There was a problem hiding this comment.
double quote vs single quote for strings
diwu1989
force-pushed
the
fix-restore
branch
4 times, most recently
from
1a6aee6
to
3b9b7ac
Compare
|
pull request cleaned up @tschaub wanna review this? |
|
Can you provide an example that demonstrates the problem (and show how this change addresses it)? It's not clear looking at the code alone. An example repo or a gist with enough code to reproduce the issue would be great. |
|
It looks like @guncha uploaded repro steps - guncha/grunt-newer-conf-corruption@1deb15b @tschaub , are you able to reproduce using that test case? Our team had to fork |
When grunt newer runs a task that fails, it will not restore the configuration leading to numerous silent bugs, especially when running newer on things like watch. Using override will solve this problem as we have no clean way to run post tasks once the main task has failed. This is basically re-creating try finally using force.
If you like this approach to solving the problem, I can create tests so we can get this merged in.
I got the idea for a force task from the comment here, gruntjs/grunt#810 (comment)