Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutimes not supported? #365

Closed
steilerDev opened this issue Sep 5, 2022 · 2 comments · Fixed by #366
Closed

lutimes not supported? #365

steilerDev opened this issue Sep 5, 2022 · 2 comments · Fixed by #366
Assignees
@3cp

Comments

@steilerDev
Copy link

I'm currently testing an app using mock-fs. This app uses fs.promises.lutimes and fs.lutimesSync to change the timestamp of symbolic links generated. Is it possible, that mockfs is not supporting this function (as lutimes throws a 'file not found' error, when using mock-fs, however I could not find any mention of this anywhere in this repo)

Thanks!
@3cp
Copy link
Collaborator

3cp commented Sep 6, 2022

I see lutimes was added in: nodejs v14.5.0, v12.19.0.
It should be possible to add the support.

@3cp 3cp self-assigned this Sep 6, 2022
@3cp
Copy link
Collaborator

3cp commented Sep 7, 2022

While working on this, also discovered that our utimes implementation has a bug, it should follow symlink but it doesn't.

3cp added a commit that referenced this issue Sep 7, 2022
@3cp
fix: fix bug on utimes, futimes, add support of lutimes
d0cb46c 
lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix
covers both versions.

closes #365
3cp added a commit that referenced this issue Sep 7, 2022
@3cp
fix: fix bug on utimes, futimes, add support of lutimes
8706fef 
lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix
covers both versions.

closes #365
3cp added a commit that referenced this issue Sep 7, 2022
@3cp
fix: fix bug on utimes, futimes, add support of lutimes
555a7dd 
lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix
covers both versions.

closes #365
@3cp 3cp mentioned this issue Sep 7, 2022
Merged
3cp added a commit that referenced this issue Sep 8, 2022
@3cp
fix: fix bug on utimes, futimes, add support of lutimes
d466ab6 
lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix
covers both versions.

closes #365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3cp 3cp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix bug on utimes, futimes, add support of lutimes tschaub/mock-fs
2 participants
@3cp @steilerDev