fix: prepatch fs-binding to improve support nodejs v10+ readFile #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cp
changed the title
Changed strategy to prepatch fs-binding methods in order to bypass nodejs v10+'s direct binding method calling. As long as you do require('mock-fs') before using any fs method, the prepatch will work for nodejs v10+ readFile.
This new patch only works for ReadFileContext (used by fs.readFile), because its require is delayed (`if (!ReadFileContext) ReadFileContext = require('internal/fs/read_file_context')`)
Previous _writev patch is still required to bypass issue on WriteStream.
fixes #264, properly fixes #254
3cp
changed the title
|
Hi @tschaub could you review this? |
tschaub
approved these changes
Apr 22, 2019
|
Thanks again for the work on this @huochunpeng. Published in mock-fs@4.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed strategy to prepatch fs-binding methods in order to bypass nodejs v10+'s direct binding method calling. As long as you do require('mock-fs') before using any fs method, the prepatch will work for nodejs v10+ readFile.
This new patch only works for ReadFileContext (used by fs.readFile), because its require is delayed (
if (!ReadFileContext) ReadFileContext = require('internal/fs/read_file_context'))Previous _writev patch is still required to bypass issue on WriteStream.
fixes #264, properly fixes #254