Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #362

Merged
merged 2 commits into from Aug 2, 2022
Merged

Dependency updates #362

merged 2 commits into from Aug 2, 2022

Conversation

tschaub
Copy link
Owner

@tschaub tschaub commented Aug 2, 2022

This updates development dependencies and fixes linter issues.

@tschaub tschaub force-pushed the updates branch 2 times, most recently from 10ac2d9 to 6478d12 Compare August 2, 2022 19:18
@3cp
Copy link
Collaborator

3cp commented Aug 2, 2022

Hi @tschaub I am interested on what tool did you use to clean up the files? prettier?

@tschaub
Copy link
Owner Author

tschaub commented Aug 2, 2022

npm run lint -- --fix (which is like npx eslint benchmarks lib test tasks --fix) did most of the work. The ESLint config uses rules from Prettier, so part of the fix (and rule enforcement) is done by Prettier. I use an ESLint integration for my editor, so the config in the package.json is checked when I edit, and I have the editor set up to fix on save.

A number of the changes (like adding the .js file extension on the imports) could not be auto-fixed. So those I did by hand. I take it as punishment for deciding to make that change in the linter config.

PS - I don't install anything like Prettier or ESLint globally and only use them if they are installed as a project dependency - and my editor setup only kicks in if a project has an ESLint configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants