Rename depreacated @transaction.commit_on_success to @transaction.atomic

[yuvadm]

Fixes these warnings:

home/user/.virtualenvs/proj/lib/python2.7/site-packages/django_facebook/utils.py:316: RemovedInDjango18Warning: commit_on_success is deprecated in favor of atomic.

The fix is a simple rename, no functionality should be affected:

atomic allows us to create a block of code within which the atomicity on the database is guaranteed. If the block of code is successfully completed, the changes are committed to the database. If there is an exception, the changes are rolled back.

https://docs.djangoproject.com/en/dev/topics/db/transactions/#django.db.transaction.atomic

[yuvadm]

@tschellenbach can we please merge this? Django 1.7 is out and anyone using django-facebook is getting deprecation warnings all over the place. This change is trivial and should pass all existing tests.

[tschellenbach]

sorry guys, things are very busy at the moment.
thanks for helping out! Open source is great (sometimes) :)

[yuvadm]

@tschellenbach no problem, thanks for the quick merge!

[johnshiver]

Is this change compatible with Django 1.5? It looks like 1.5 doesnt support @transaction.atomic

[yuvadm]

@johnshiver This is a non-backwards-compatible change, but Django 1.5 is not supported anymore. You can argue that since 1.4 is an LTS version it might need to be supported, but I'm not sure about @tschellenbach's policy on that, you might just need to use an old version of django-facebook as well.

[johnshiver]

@yuvadm Thanks for the reply! Yeah I will be using 5.3.1 for the time being, just wanted to comment since the docs say the minimum required django version is 1.5, whereas with this change perhaps it should say 1.6