Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty email field solutions #602

Merged
merged 2 commits into from Oct 20, 2017
Merged

Conversation

mach24
Copy link
Contributor

@mach24 mach24 commented Oct 20, 2017

These edits solve two issues leading to empty email fields from the Graph API.

  1. The email field is explicitly required in the API call.
  2. User didn't give permission or because of Facebook privacy/security policies.

Refer Facebook bug

In case the email field is not available because user refused permission, or because of Facebook verification or other policies, then just generate a dummy email from the username. This ensures that the registration does not fail.
@tschellenbach
Copy link
Owner

Thanks for this pull request. It looks good, merging now.

@tschellenbach tschellenbach merged commit c1f704d into tschellenbach:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants