Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenQuandLatticeDrudge (#12) and subst with numbers #13

Closed
wants to merge 22 commits into from
Closed

Fix GenQuandLatticeDrudge (#12) and subst with numbers #13

wants to merge 22 commits into from

Conversation

chenpeizhi
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 86.934% when pulling b0fe63e on chenpeizhi:master into b170c4d on tschijnmo:master.

Copy link
Owner

@tschijnmo tschijnmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , only some unimportant nit comments were added. It can be rebased and merged to separate out the type-fixing commit, a single squash is also good, entirely up to your convenience.

tests/genquad_test.py Outdated Show resolved Hide resolved
tests/genquad_test.py Outdated Show resolved Hide resolved
@chenpeizhi chenpeizhi changed the title Fixes #12 Fix GenQuandLatticeDrudge (#12) and subst with numbers Dec 11, 2019
@chenpeizhi
Copy link
Collaborator Author

I was testing GitHub Actions and messed up this PR. I have squashed the commits and pushed using command line. I therefore close this PR.

@chenpeizhi chenpeizhi closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants