Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with rc2020-06-01 "Hogfather" #7

Closed
mtkirchner opened this issue Jun 4, 2020 · 2 comments · Fixed by #8
Closed

Breaks with rc2020-06-01 "Hogfather" #7

mtkirchner opened this issue Jun 4, 2020 · 2 comments · Fixed by #8

Comments

@mtkirchner
Copy link

PHP Fatal error: Declaration of action_plugin_stars2::register(&$controller) must be compatible with dokuwiki\Extension\ActionPlugin::register(Doku_Event_Handler $controller) in /lib/plugins/stars2/action.php on line 0

@tschinz
Copy link
Owner

tschinz commented Jun 12, 2020

Well the Progin has to be updated becaues of the changes made in the action plugin system in Hogfather. Action Plugin informatin can be found here.
Unfortunately I don't use or support the Dokuwiki Plugins is anymore. If there is somebody willing to take it over I'm gald to do so.
If you fix it yourself and send me a pull request, I'm happy to do so also.

The fix should be very minimal.

Thanks for you understanding

@lepperm
Copy link
Contributor

lepperm commented Jul 7, 2020

Submitted a pull request to resolve: #8
Thanks!

@tschinz tschinz closed this as completed in #8 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants