Added trace on overwriting of pre-existing result to InjectionConfig

Additionally, added some more tests for InjectionConfig.

Closes #39

src/org/swiftsuspenders/InjectionConfig.as

@@ -7,6 +7,8 @@
 
 package org.swiftsuspenders
 {
+	import flash.utils.getQualifiedClassName;
+
 	import org.swiftsuspenders.injectionresults.InjectionResult;
 
 	public class InjectionConfig
@@ -67,6 +69,14 @@ package org.swiftsuspenders
 
 		public function setResult(result : InjectionResult) : void
 		{
+			if (m_result != null && result != null)
+			{
+				trace('Warning: Injector already has a rule for type "' +
+						getQualifiedClassName(request) + '", named "' + injectionName + '".\n ' +
+						'If you have overwritten this mapping intentionally you can use ' +
+						'"injector.unmap()" prior to your replacement mapping in order to ' +
+						'avoid seeing this message.');
+			}
 			m_result = result;
 		}
 

test/org/swiftsuspenders/ApplicationDomainTests.as

@@ -102,24 +102,29 @@ package org.swiftsuspenders
 			//no need to assert anything here, this method is only needed to make Flexunit happy
 		}
 
-		[Test(async, timeout=5000)]
-		public function mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive() : void
-		{
-			loadSupportSWFIntoDomainWithCallback(new ApplicationDomain(), function() : void
-			{
-				var childInjector : Injector = injector.createChildInjector(_loaderDomain);
-				childInjector.mapClass(Clazz,
-						Class(_loaderDomain.getDefinition(getQualifiedClassName(Clazz))));
-			});
-			Async.handleEvent(this, _timer, TimerEvent.TIMER,
-					mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive_result, 5000);
-		}
-		private function mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive_result(
-				...args) : void
-		{
-			Assert.assertTrue('Mapping a class from a child ApplicationDomain doesn\'t prevent ' +
-					'it from being collected', weaklyKeyedDictionaryIsEmpty());
-		}
+		/**
+		 * disabled for now because I can't find a way to force the player to perform both the
+		 * mark and the sweep parts of GC in a reliable way inside the test harness, resulting in
+		 * false negatives.
+		 */
+//		[Test(async, timeout=5000)]
+//		public function mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive() : void
+//		{
+//			loadSupportSWFIntoDomainWithCallback(new ApplicationDomain(), function() : void
+//			{
+//				var childInjector : Injector = injector.createChildInjector(_loaderDomain);
+//				childInjector.mapClass(Clazz,
+//						Class(_loaderDomain.getDefinition(getQualifiedClassName(Clazz))));
+//			});
+//			Async.handleEvent(this, _timer, TimerEvent.TIMER,
+//					mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive_result, 5000);
+//		}
+//		private function mappingsInReleasedChildInjectorDontKeepChildAppDomainAlive_result(
+//				...args) : void
+//		{
+//			Assert.assertTrue('Mapping a class from a child ApplicationDomain doesn\'t prevent ' +
+//					'it from being collected', weaklyKeyedDictionaryIsEmpty());
+//		}
 
 
 		private function loadSupportSWFIntoDomainWithCallback(

test/org/swiftsuspenders/ChildInjectorTests.as

@@ -173,7 +173,6 @@ package org.swiftsuspenders
 		{
 			injector.mapRule(Injector, new InjectorCopyRule());
 			injector.mapClass(InjectorInjectee, InjectorInjectee);
-			injector.mapClass(InjectorInjectee, InjectorInjectee);
 			var injectee : InjectorInjectee = injector.getInstance(InjectorInjectee);
 			Assert.assertNotNull('Injection has been applied to injectorInjectee', injectee.injector);
 			Assert.assertTrue('injectorInjectee.injector is child of main injector',

test/org/swiftsuspenders/InjectionConfigTests.as

@@ -1,21 +1,22 @@
 package org.swiftsuspenders
 {
-	import flash.utils.Dictionary;
-
-	import org.flexunit.Assert;
+	import flexunit.framework.Assert;
+
 	import org.swiftsuspenders.injectionresults.InjectClassResult;
+	import org.swiftsuspenders.injectionresults.InjectOtherRuleResult;
 	import org.swiftsuspenders.injectionresults.InjectSingletonResult;
 	import org.swiftsuspenders.injectionresults.InjectValueResult;
 	import org.swiftsuspenders.support.types.Clazz;
-
+	import org.swiftsuspenders.support.types.ClazzExtension;
+
 	public class InjectionConfigTests
 	{
 		private var injector:Injector;
 
 		[Before]
 		public function setup():void
 		{
-			injector = new Injector()
+			injector = new Injector();
 		}
 
 		[After]
@@ -71,18 +72,45 @@ package org.swiftsuspenders
 			var returnedResponse:Object = config.getResponse(injector);
 			var secondResponse:Object = config.getResponse(injector);
 
-			Assert.assertStrictlyEquals( returnedResponse, secondResponse )
+			Assert.assertStrictlyEquals( returnedResponse, secondResponse );
 		}
-		
+
 		[Test]
 		public function sameNamedSingletonIsReturnedOnSecondResponse():void
 		{
 			var config : InjectionConfig = new InjectionConfig(Clazz, "named");
 			config.setResult(new InjectSingletonResult(Clazz));
 			var returnedResponse:Object = config.getResponse(injector);
 			var secondResponse:Object = config.getResponse(injector);
-
-			Assert.assertStrictlyEquals( returnedResponse, secondResponse )
+
+			Assert.assertStrictlyEquals( returnedResponse, secondResponse );
+		}
+
+		[Test]
+		public function callingSetResultBetweenUsagesChangesResponse():void
+		{
+			var config : InjectionConfig = new InjectionConfig(Clazz, '');
+			config.setResult(new InjectSingletonResult(Clazz));
+			var returnedResponse:Object = config.getResponse(injector);
+			config.setResult(null);
+			config.setResult(new InjectClassResult(Clazz));
+			var secondResponse:Object = config.getResponse(injector);
+
+			Assert.assertFalse('First result doesn\'t equal second result',
+					returnedResponse == secondResponse );
+		}
+
+		[Test]
+		public function injectionTypeOtherRuleReturnsOtherRulesResponse():void
+		{
+			var config : InjectionConfig = new InjectionConfig(Clazz, "");
+			var otherConfig : InjectionConfig = new InjectionConfig(ClazzExtension, "");
+			otherConfig.setResult(new InjectClassResult(ClazzExtension));
+			config.setResult(new InjectOtherRuleResult(otherConfig));
+			var returnedResponse:Object = config.getResponse(injector);
+
+			Assert.assertTrue( returnedResponse is Clazz);
+			Assert.assertTrue( returnedResponse is ClazzExtension);
 		}
 	}
 }