Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO refactor #183

Merged
merged 10 commits into from
Apr 30, 2024
Merged

IO refactor #183

merged 10 commits into from
Apr 30, 2024

Conversation

Calvinxc1
Copy link
Collaborator

@Calvinxc1 Calvinxc1 commented Apr 26, 2024

Refactored all of the IO files to the new multi-file format.

Notes:

  • I started reviewing a few more of the warnings that my IDE was presenting me with as I was moving classes into their respective files. I added a small plethora of TODO's in the code where I found some oddities that may want to be revisited in future code cleanups.
  • A bit of my QC work drifted into this branch at first. I corrected that with 03e25d9.

@Calvinxc1 Calvinxc1 self-assigned this Apr 26, 2024
docs/gen_doc_stubs.py Outdated Show resolved Hide resolved
tsdat/io/base/var_name.py Outdated Show resolved Hide resolved
tsdat/io/retrievers/improved_default_retriever.py Outdated Show resolved Hide resolved
Comment on lines +334 to 337
# TODO: Looks like a documentation reference here to `converters.py`. Should be changed
# given the refactor.

# tsdat/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is leftover design work that somehow made it in here. This was when we were sketching out the layout for the transform submodules. Old stuff. This can all be deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this when I make a pass through the transform folder.

@Calvinxc1 Calvinxc1 merged commit 41dc27e into main Apr 30, 2024
4 of 6 checks passed
@Calvinxc1 Calvinxc1 deleted the io_refactor branch April 30, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants