New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(`expectError`): report missing diagnostic codes #178

Merged

sindresorhus merged 3 commits into tsdjs:main from tommy-mitchell:fix-expect-error-message

Mar 10, 2023

Contributor

tommy-mitchell commented Mar 9, 2023 •

edited

Implements #177 (comment).

expectError now behaves in three ways:

If an error is a syntactic error (diagnostic code less than 2000), don't display Expected an error message
If no error exists, log Expected an error, but found none.
Otherwise, log Found an error that tsd does not currently support (tsXXXX), consider creating an issue on GitHub.

tommy-mitchell added 2 commits

March 9, 2023 13:49


          tests(expectError): move to new file

6c8ae0f


          fix(expectError): report missing diagnostic code

e184665

Contributor Author

tommy-mitchell commented Mar 9, 2023

Should probably also document in the readme that syntax errors can’t be ignored.


          docs(expectError): note about syntax errors

357cdd6

sindresorhus merged commit b4503d0 into tsdjs:main

Collaborator

sindresorhus commented Mar 10, 2023

Thanks :)

tommy-mitchell mentioned this pull request

Towards v1.0.0 #196

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment