Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for globbing patterns in files property - fixes #69 #70

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Add support for globbing patterns in files property - fixes #69 #70

merged 4 commits into from
Jun 29, 2020

Conversation

Lusito
Copy link
Contributor

@Lusito Lusito commented May 7, 2020

files can contain directories and globs: https://docs.npmjs.com/files/package.json#files

This fixes it, including tests.

It also fixes a wrong url in the package.json

@Lusito
Copy link
Contributor Author

Lusito commented May 7, 2020

I guess I was a little eager to fix this, #48 seems to be about the same thing. My PR doesn't introduce a new dependency though.

Copy link
Collaborator

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I prefer not to use an extra dependency and rather use globby. With globby we explicitely check for the existence of the file.

Nice work!

@SamVerschueren SamVerschueren changed the title Allow glob files Add support for globbing patterns in files property - fixes #69 Jun 29, 2020
@SamVerschueren SamVerschueren merged commit f8b3f81 into tsdjs:master Jun 29, 2020
@Lusito Lusito deleted the allow-glob-files branch June 29, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants