Merge pull request #333 from tsedio/fix-yarn-berry

fix(cli-core): remove unsupported option for yarn berry
tsedio · Jun 12, 2023 · b9a2fd0 · b9a2fd0
2 parents dc498a3 + e4e872e
commit b9a2fd0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/cli-core/src/services/packageManagers/YarnBerryManager.spec.ts b/packages/cli-core/src/services/packageManagers/YarnBerryManager.spec.ts
@@ -36,7 +36,7 @@ describe("YarnBerryManager", () => {
 
       await manager.add(["deps"], {});
 
-      expect(cliExeca.run).toHaveBeenCalledWith("yarn", ["add", "--ignore-engines", "deps"], {});
+      expect(cliExeca.run).toHaveBeenCalledWith("yarn", ["add", "deps"], {});
     });
   });
   describe("addDev()", () => {
@@ -45,7 +45,7 @@ describe("YarnBerryManager", () => {
 
       await manager.addDev(["deps"], {});
 
-      expect(cliExeca.run).toHaveBeenCalledWith("yarn", ["add", "-D", "--ignore-engines", "deps"], {});
+      expect(cliExeca.run).toHaveBeenCalledWith("yarn", ["add", "-D", "deps"], {});
     });
   });
   describe("install()", () => {

diff --git a/packages/cli-core/src/services/packageManagers/YarnBerryManager.ts b/packages/cli-core/src/services/packageManagers/YarnBerryManager.ts
@@ -29,11 +29,11 @@ export class YarnBerryManager extends BaseManager {
   }
 
   add(deps: string[], options: ManagerCmdOpts) {
-    return this.run("add", ["--ignore-engines", ...deps], options);
+    return this.run("add", [...deps], options);
   }
 
   addDev(deps: string[], options: ManagerCmdOpts) {
-    return this.run("add", ["-D", "--ignore-engines", ...deps], options);
+    return this.run("add", ["-D", ...deps], options);
   }
 
   install(options: {verbose?: boolean} & execa.Options): Observable<any> {