Compatibility and memory footprint issues with @SocketSession decorator

[derevnjuk]

Information

• Version: 7.x
• Packages: @tsed/socketio

The @tsed/socketio library utilizes in-memory session storage allowing injecting the session data through @SocketSession decorator. However, this implementation is not compatible with socket.io adapters and the connection state recovery feature. Additionally, this approach can cause a growing memory footprint over time, which may impact the application's performance and stability.

To address the compatibility and memory footprint concerns, the usage of the @SocketSession decorator should be reworked. Instead of relying on in-memory session storage, the decorator should be modified to inject the value of socket.data, preserving backward compatibility with existing SocketIO implementations.

Example

@SocketService("/my-namespace")
export class MySocketService {
  $onConnection(@Socket socket: SocketIO.Socket, @SocketSession session: SocketSession) {
    if (socket.recovered) {
      // recovery was successful after the server crash, rolling update, etc
      console.log(session.get('key1')); // outputs value1
    } else {
      // new or unrecoverable session
      session.set('key1', 'value1');
    }
  }
}

[github-actions]

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

[Romakita]

🎉 This issue has been resolved in version 7.34.1 🎉

The release is available on:

• v7.34.1
• GitHub release

Your semantic-release bot 📦🚀