Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TSC cant build @tsc\schema Cannot find module '\node_modules\@tsed\schema\lib\esm\components.js' #2411

Closed
1 task
DaniGTA opened this issue Aug 19, 2023 · 4 comments

Comments

@DaniGTA
Copy link

DaniGTA commented Aug 19, 2023

Information

  • Version: 7.34.5
  • Packages:
    "@tsed/common": "^7.34.5",
    "@tsed/components-scan": "^7.34.5",
    "@tsed/core": "^7.34.5",
    "@tsed/di": "^7.34.5",
    "@tsed/exceptions": "^7.34.5",
    "@tsed/json-mapper": "^7.34.5",
    "@tsed/platform-express": "^7.34.5",
    "@tsed/schema": "^7.34.5",
    "@tsed/socketio": "^7.34.5",

Example

I upgrade from ^7.34.2 to ^7.34.5 and was running npm ci

Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'myfolder\node_modules\@tsed\schema\lib\esm\components.js' imported from myfolder\node_modules\@tsed\schema\lib\esm\utils\getJsonSchema.js

I checked the node modules my self and
image
image
there is no components .js

Acceptance criteria

  • successfull tsc build with @tsed/schema esm modules
@DaniGTA DaniGTA changed the title [BUG] TSC cant build @tsc\schema Cannot find module '\node_modules\@tsed\schema\lib\esm\components.js` [BUG] TSC cant build @tsc\schema Cannot find module '\node_modules\@tsed\schema\lib\esm\components.js Aug 19, 2023
@DaniGTA DaniGTA changed the title [BUG] TSC cant build @tsc\schema Cannot find module '\node_modules\@tsed\schema\lib\esm\components.js [BUG] TSC cant build @tsc\schema Cannot find module '\node_modules\@tsed\schema\lib\esm\components.js' Aug 19, 2023
@Romakita
Copy link
Collaborator

Ha it's because in esm I have to write an explicite import of the correct file : components/index.js
I'll try to fix that

Romakita added a commit that referenced this issue Aug 20, 2023
@github-actions
Copy link

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

github opencollective

@Romakita
Copy link
Collaborator

🎉 This issue has been resolved in version 7.34.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator

Romakita commented Sep 6, 2023

🎉 This issue has been resolved in version 7.35.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants