Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): before middleware should execute before use middleware #1597

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix(common): before middleware should execute before use middleware #1597

merged 1 commit into from
Oct 27, 2021

Conversation

Oatelaus
Copy link
Contributor

@Oatelaus Oatelaus commented Oct 21, 2021 •
edited
Loading

This fixes #1594 and will execute before middleware before it executes use middleware.

@Oatelaus
Copy link
Contributor Author

I'll get it right first time one day, sorry @Romakita - Ive just seen the CONTRIBUTORS file

@Romakita
Copy link
Collaborator

Thanks for the PR @Fedelaus. You have to update the unit test ;)

@Oatelaus
Copy link
Contributor Author

@Romakita I'll get there sorry, busy at work the last few days

@Romakita
Copy link
Collaborator

I updated your PR ;). I'll merge it soon!

@Romakita Romakita merged commit 3986dfb into tsedio:production Oct 27, 2021
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 6.75.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Oatelaus
Copy link
Contributor Author

@Romakita thank you so much, sorry for doing half the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romakita Romakita Romakita approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Call sequence from the doc is not respected for middleware
2 participants
@Oatelaus @Romakita