Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback changes introduced by v6.116.0 on the async hook context #1973

Merged
merged 1 commit into from Jul 6, 2022

Conversation

Romakita
Copy link
Collaborator

@Romakita Romakita commented Jul 6, 2022

Information

Fix the issue related to the context creation and binding with the async_hook_context.

Fix the issue when we use the @InjectContext() decorator!

@Romakita Romakita force-pushed the fix-1949-async-context-regression branch from 73cf7b8 to 09f38ee Compare July 6, 2022 10:03
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 2050 574.47KB - -
Ts.ED Koa 2520 502.11KB - -
Nest-Express 3397 792.76KB - -
Nest-Fastify 10317 1.73MB - -
Express 3894 0.89MB - -
Express Router 3678 858.53KB - -
Koa 8544 1.43MB - -
Fastify 10658 1.79MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 1437 402.64KB - -
Ts.ED Koa 1875 373.58KB - -
Nest-Express 2484 579.72KB - -
Nest-Fastify 5727 0.96MB - -
Express 2622 612.07KB - -
Express Router 2607 608.46KB - -
Koa 5815 0.98MB - -
Fastify 6365 1.07MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita Romakita merged commit f0051c0 into production Jul 6, 2022
@Romakita Romakita deleted the fix-1949-async-context-regression branch July 6, 2022 11:07
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 1399 392.21KB - -
Ts.ED Koa 1752 349.00KB - -
Nest-Express 2142 499.88KB - -
Nest-Fastify 5041 866.42KB - -
Express 2409 562.37KB - -
Express Router 2334 544.67KB - -
Koa 4944 849.77KB - -
Fastify 5525 0.93MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita
Copy link
Collaborator Author

Romakita commented Jul 6, 2022

🎉 This PR is included in version 6.116.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 7.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant