Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2487 graphql v1v2 endpoints does not work #2503

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

Romakita
Copy link
Collaborator

@Romakita Romakita commented Nov 1, 2023

Information

Closes: #2487

Type Breaking change
Feature No

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Romakita Romakita linked an issue Nov 1, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 1, 2023

Benchmarks

  • Machine: linux x64 | 2 vCPUs | 6.8GB Mem
  • Node: v16.20.2
  • Run: Wed Nov 01 2023 09:48:13 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
fastify 3.29.4 45865.6 21.36 8.18
nest-fastify 8.4.3 40121.6 24.49 7.15
koa 2.13.4 35388.0 27.81 6.31
fastify-injector 3.29.4 22910.8 43.04 5.22
express 4.18.1 8842.2 112.32 1.58
tsed-koa 7.41.2 7834.2 126.76 6.84
fastify-big-json 3.29.4 7608.0 130.53 87.53
nest 8.4.3 7592.4 130.52 1.82
express-injector 4.18.1 7031.5 141.00 1.60
tsed-express 7.41.2 6436.6 153.92 1.18
express-morgan 4.18.1 5000.6 198.00 0.89

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita force-pushed the 2487-graphql-v1v2-endpoints-does-not-work branch from b503f2e to b81471c Compare November 1, 2023 10:02
Copy link

github-actions bot commented Nov 1, 2023

Benchmarks

  • Machine: linux x64 | 2 vCPUs | 6.8GB Mem
  • Node: v16.20.2
  • Run: Wed Nov 01 2023 10:16:09 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
fastify 3.29.4 54985.6 17.76 9.81
nest-fastify 8.4.3 49222.4 19.86 8.78
koa 2.13.4 41500.8 23.60 7.40
fastify-injector 3.29.4 27976.0 35.29 6.38
express 4.18.1 11093.6 89.38 1.98
fastify-big-json 3.29.4 10256.0 96.71 117.99
tsed-koa 7.41.2 10103.5 98.14 8.83
nest 8.4.3 9961.0 99.59 2.39
express-injector 4.18.1 9056.5 109.46 2.06
tsed-express 7.41.2 8423.4 117.73 1.54
express-morgan 4.18.1 6663.1 148.74 1.19

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita force-pushed the 2487-graphql-v1v2-endpoints-does-not-work branch from b81471c to 7558a2e Compare November 1, 2023 10:16
Copy link

github-actions bot commented Nov 1, 2023

Benchmarks

  • Machine: linux x64 | 2 vCPUs | 6.8GB Mem
  • Node: v16.20.2
  • Run: Wed Nov 01 2023 10:31:07 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
fastify 3.29.4 42224.0 23.22 7.53
nest-fastify 8.4.3 37589.6 26.19 6.70
koa 2.13.4 31954.4 30.87 5.70
fastify-injector 3.29.4 21586.0 45.90 4.92
express 4.18.1 8261.8 120.09 1.47
tsed-koa 7.41.2 7529.1 131.53 6.58
nest 8.4.3 7054.0 140.54 1.70
fastify-big-json 3.29.4 7007.6 141.51 80.61
express-injector 4.18.1 6710.4 147.77 1.53
tsed-express 7.41.2 5764.4 171.85 1.06
express-morgan 4.18.1 4727.1 209.39 0.84

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita force-pushed the 2487-graphql-v1v2-endpoints-does-not-work branch from 7558a2e to 7f52081 Compare November 1, 2023 11:29
Copy link

github-actions bot commented Nov 1, 2023

Benchmarks

  • Machine: linux x64 | 2 vCPUs | 6.8GB Mem
  • Node: v16.20.2
  • Run: Wed Nov 01 2023 11:42:23 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
fastify 3.29.4 57974.4 16.80 10.34
nest-fastify 8.4.3 50435.2 19.34 8.99
koa 2.13.4 43846.4 22.32 7.82
fastify-injector 3.29.4 29731.2 33.16 6.78
express 4.18.1 11463.2 86.60 2.04
fastify-big-json 3.29.4 10560.0 93.84 121.47
tsed-koa 7.41.2 10350.0 95.76 9.04
nest 8.4.3 10274.0 96.54 2.47
express-injector 4.18.1 9383.8 105.70 2.14
tsed-express 7.41.2 8552.2 115.87 1.57
express-morgan 4.18.1 6879.1 144.03 1.23

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita merged commit d8373c7 into production Nov 1, 2023
36 checks passed
@Romakita Romakita deleted the 2487-graphql-v1v2-endpoints-does-not-work branch November 1, 2023 11:58
@Romakita
Copy link
Collaborator Author

Romakita commented Nov 1, 2023

🎉 This PR is included in version 7.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphql v1/v2 endpoints does not work
1 participant