-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform-params): make RawPathParams configurable like is it for PathParams (useValidation, useType, etc...) #2517
Conversation
Benchmarks
ExplanationThe benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance. For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary. All this at a necessary cost that reflects the reality of a production application ;) |
… PathParams (useValidation, useType, etc...) Closes: #2515
8713696
to
8bf8d76
Compare
Benchmarks
ExplanationThe benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance. For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary. All this at a necessary cost that reflects the reality of a production application ;) |
expression | ||
expression, | ||
useValidation, | ||
useMapper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about useMapper
and useType
here, because if a user would use them, then it would make no sense to use RawPathParams
over PathParams
, would it? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes... I realize, is just an equivalent of PathParams with the correct option XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will say that this will allow the dev to customize the behavior of the decorator starting from the case where everything is false (and vice versa).
🎉 This PR is included in version 7.44.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes: #2515