Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swagger): fix resolved path in windows OS context #2693

Merged
merged 1 commit into from
May 3, 2024

Conversation

Romakita
Copy link
Collaborator

@Romakita Romakita commented May 3, 2024

Closes: #2692

Copy link

github-actions bot commented May 3, 2024

Benchmarks

  • Machine: linux x64 | 4 vCPUs | 15.6GB Mem
  • Node: v18.20.2
  • Run: Fri May 03 2024 09:21:01 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
koa 2.13.4 35090.2 27.97 6.26
tsed-koa 7.68.3 12057.8 82.19 10.21
express 4.19.2 10832.4 91.51 1.93
express-injector 4.19.2 9937.1 99.64 2.27
nest 8.4.3 9533.8 103.81 2.29
tsed-express 7.68.3 9045.6 109.59 1.66
express-morgan 4.19.2 5671.5 174.60 1.01
fastify-big-json 3.29.4 N/A N/A N/A
fastify-injector 3.29.4 N/A N/A N/A
fastify 3.29.4 N/A N/A N/A
nest-fastify 8.4.3 N/A N/A N/A

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

Copy link

@VictoriqueMoe VictoriqueMoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried this branch locally and works on win

@Romakita Romakita merged commit 799e563 into production May 3, 2024
15 checks passed
@Romakita Romakita deleted the fix-2692-win-swagger-ui-dist-path branch May 3, 2024 15:15
@Romakita
Copy link
Collaborator Author

Romakita commented May 3, 2024

🎉 This PR is included in version 7.68.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Swagger UI no longer loads
2 participants