Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add appendChildrenRoutesFirst configuration option #2711

Merged
merged 4 commits into from
May 27, 2024

Conversation

EinfachHans
Copy link
Contributor

Information

Type Breaking change
Feature No

closes #2706


Description

As described in the original issue the children routes should be appended before the controller routes itself. This PR adds a opt-in solution via a configuration setting. As discussed we should follow the following:

  • In next major release (8.0.0): Set the default of this value to true & deprecate the option
  • In the next major version after that (9.0.0): Remove the option

Usage example

import {Configuration} from "@tsed/di";

@Configuration({
  appendChildrenRoutesFirst: true
})
export class Server {}

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@EinfachHans EinfachHans requested a review from Romakita May 25, 2024 08:40
@Romakita
Copy link
Collaborator

@EinfachHans Perfect ;)

@Romakita Romakita merged commit a61e6ae into tsedio:production May 27, 2024
15 checks passed
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 7.70.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Children Controller Routes should be declared before parent
2 participants