Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces.ts #2725

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update interfaces.ts #2725

merged 1 commit into from
Jun 13, 2024

Conversation

csprance
Copy link
Contributor

@csprance csprance commented Jun 13, 2024

Getting the following error when I run build because of this type here.

I think it might be a bit too broad. Scoped it down to be Record<string, any> which seems like a better fit than object

$ barrelsby --config .barrelsby.json
node_modules/@tsed/platform-cache/lib/types/interfaces/interfaces.d.ts:13:82 - error TS2344: Type 'Config' does not satisfy the constraint 'Record<string, unknown>'.
  Type 'object' is not assignable to type 'Record<string, unknown>'.
    Index signature for type 'string' is missing in type '{}'.

13     store?: "memory" | Store | PlatformCacheLegacyStoreFactory | FactoryStore<S, Config>;
                                                                                    ~~~~~~


Found 1 error in node_modules/@tsed/platform-cache/lib/types/interfaces/interfaces.d.ts:13

Information

Type Breaking change
Fix No

Getting the following error when I run build because of this type here. I think it might be a bit too broad. Scoped it down to be Record<string, any> which seems like a better fit than object

$ barrelsby --config .barrelsby.json
node_modules/@tsed/platform-cache/lib/types/interfaces/interfaces.d.ts:13:82 - error TS2344: Type 'Config' does not satisfy the constraint 'Record<string, unknown>'.
  Type 'object' is not assignable to type 'Record<string, unknown>'.
    Index signature for type 'string' is missing in type '{}'.

13     store?: "memory" | Store | PlatformCacheLegacyStoreFactory | FactoryStore<S, Config>;
                                                                                    ~~~~~~


Found 1 error in node_modules/@tsed/platform-cache/lib/types/interfaces/interfaces.d.ts:13
@Romakita Romakita merged commit a829a95 into tsedio:production Jun 13, 2024
15 checks passed
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 7.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@csprance
Copy link
Contributor Author

Sweet! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants