-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.24 regression in Fedora build system (Boost::Geometry::Utils, slic3r): Missing -xc++ #26
Comments
Thanks for the report! It seems my good idea caused chaos. Sorry about that. |
Released as 0.25. |
Unfortunately, this still doesn't pass the tests in Fedora:
BTW no need to release a new version immediately I can test a pull request before it is merged. |
@hroncok Can you try editing |
That makes the actual tests pass, I will now try to build Boost::Geometry::Utils and slic3r |
Great! Looking forward to seeing if it actually works ;-) |
Yes! 0.25 actually works now, it was only the test that was not isolated enough. Thanks! |
Thank you for the help! Released as 0.26. |
Hello,
with the update to 0.24, we see a regression in at least 2 dependent packages of this and in the tests of this library itself.
The environment
Our build system sets:
The test failure
And we get:
At first, I assumed the tests simply cannot run in an environment, where the environment variables are set, so I've done:
Before running the tests, but that was not a good idea, this affected dependent packages.
The dependent packages problem
E.g. when we build perl-Boost-Geometry-Utils we set the flags similarly. With the previous version (0.23), the build happened as:
Now it builds as:
The error in compilation is:
Diff of the individual flags:
sic3r has a similar problem.
I think the missing
-xc++
is a problem. But I am not sure, I don't do much Perl unfortunately, I maintain this in Fedora only because of slic3r.The text was updated successfully, but these errors were encountered: