Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive #3

Open
kmulvey opened this issue Mar 16, 2016 · 2 comments
Open

false positive #3

kmulvey opened this issue Mar 16, 2016 · 2 comments

Comments

@kmulvey
Copy link

kmulvey commented Mar 16, 2016

deadcode
deadcode: oauth_helpers.go:70:1: validateJWS is unused

grep validateJWS *
oauth_helpers.go:// validateJWS gets the access token
oauth_helpers.go:func validateJWS(accessToken string) []byte {
test_cases_test.go: claims := unmarshalJWT(validateJWS(access))
test_cases_test.go: claims := unmarshalJWT(validateJWS(string(validateJWE(access))))
@sheerun
Copy link

sheerun commented Mar 7, 2017

yeah, it doesn't support calling private functions / consts across files

@ferhatelmas ferhatelmas mentioned this issue Nov 17, 2017
Closed
@Dieterbe
Copy link

seems like this is fixed upstream remyoudompheng/go-misc#8

endocrimes added a commit to hashicorp/nomad that referenced this issue Jan 14, 2019
@endocrimes
chore: Fix docker test linting
46a7d4d 
Due to tsenart/deadcode#3 we can't specify
these consts on their own. This moves them into the _platform_test.go
files to avoid creating a package that only exposes a couple of values.
endocrimes added a commit to hashicorp/nomad that referenced this issue Jan 17, 2019
@endocrimes
chore: Fix docker test linting
3f3eb68 
Due to tsenart/deadcode#3 we can't specify
these consts on their own. This moves them into the _platform_test.go
files to avoid creating a package that only exposes a couple of values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dieterbe @kmulvey @sheerun