Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting a image #39

Closed
OleMchls opened this issue Jan 17, 2014 · 3 comments
Closed

Plotting a image #39

OleMchls opened this issue Jan 17, 2014 · 3 comments

Comments

@OleMchls
Copy link
Contributor

Hey,

I'd like to suggest to let vegeta reporter also support plotting into a image. I would need it because I've quite a bunch of result files and would like to compare the results with multiple images.

cheers! 🏮
@tsenart
Copy link
Owner

tsenart commented Jan 17, 2014

What method do you use to compare them? Do you stack images next to each other and then visually analyse them? If that's the case, what stops you from doing the same with browser windows?

@OleMchls
Copy link
Contributor Author

It's just that I can't embed browser windows like I can embed images. But
I've an idea already for a PR. Let me check that and I might send a PR if
that works :D

On Friday, January 17, 2014, Tomás Senart notifications@github.com wrote:

What method do you use to compare them? Do you stack images next to each
other and then visually analyse them? If that's the case, what stops you
from doing the same with browser windows?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/39#issuecomment-32628632
.

@tsenart
Copy link
Owner

tsenart commented Jan 17, 2014

Well, you can embed HTML pages easily with iframes. What do you have in mind for that PR?

OleMchls added a commit to OleMchls/vegeta that referenced this issue Jan 17, 2014
@OleMchls
add download button to plot renderer
e42169c 
So people can download (at least) the canvas image.
X and Y axis labels are not included. This is more a hack then a actual implementation. But it works! But it show that this is possible.

refs tsenart#39
@OleMchls OleMchls mentioned this issue Jan 17, 2014
Merged
@tsenart tsenart closed this as completed Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsenart @OleMchls