Updated tcp_handler interface to match latest (but didn't implement anything new) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'm currently only using one client per rosbridge node, but I'll see if I run into the same issue with adding multiple clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried getting your tcp_handler working with the latest RobotWebTools:ros2 branch but was unable to take it over the finish line. These changes are a step in the right direction.
This patch enables it to launch and appears to work with one client, but I'm unable to get two clients to connect. The second client will seem to connect but do nothing until the first disconnects.
call_services_in_new_threadis unimplemented (but the parameter needs to exist).