Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

If a user uses the back button to get back into an AW form to edit, cancel checkout fails #1034

Open
gsteimer opened this issue Mar 3, 2016 · 2 comments

Comments

@gsteimer
Copy link
Contributor

gsteimer commented Mar 3, 2016

A couple of things with the fix for #1021:

issue
After using the back button to get into an AW form, if you try to cancel the checkout (exit without saving), an error is thrown:

2016-03-03 13:36:58,752 48296744    TP-Processor8   ERROR   RESTService required condition condition-lockedbyme   failed, cannot execute action
com.tsgrp.opencontent.core.exception.OCRuntimeException: required condition condition-lockedbyme   failed, cannot execute action
    at com.tsgrp.opencontent.core.action.executer.AbstractActionExecuter.execute(AbstractActionExecuter.java:179)
    at com.tsgrp.opencontent.core.action.service.CoreActionService.execute(CoreActionService.java:321)

It looks like the code that fixed #1021 simply sends the user to the newest version of the form - it doesn't actually check it out again.

Enhancement
While fixing this, can we give the use a "no" option when using the back button? Our solution to #1021 fixes the issue, but also basically forces the user to edit the form. We should give the user the option to not edit the form.

image

FYI - @benallenallen @mikeblum @alieblich

@mikeblum
Copy link
Contributor

mikeblum commented Mar 3, 2016

so if the user selects OK we need to make sure the checkout happens when visiting a /edit/ route and then add a cancel button that hits the /exit route.

@gsteimer
Copy link
Contributor Author

gsteimer commented Mar 3, 2016

yep - probably hook up the [X] in the top right to do the same thing as the [Cancel] button. Right now, no matter what you do, it takes the user into editing the current form (without checking it out)

@gsteimer gsteimer modified the milestones: HPI 2.5, HPI 2.6 Apr 18, 2017
@gsteimer gsteimer modified the milestones: 3.0, 3.1 May 11, 2018
@gsteimer gsteimer modified the milestones: 3.1, Upon Client Request Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants