Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Capstone Kanban Board πŸ‘¨β€πŸ’» πŸ‘¨β€πŸ’» πŸ‘¨β€πŸ’» #5

Closed
tsheporamantso opened this issue Feb 23, 2024 · 4 comments

Comments

@tsheporamantso
Copy link
Owner

tsheporamantso commented Feb 23, 2024

Final Capstone Kanban Board πŸ‘¨β€πŸ’» πŸ‘¨β€πŸ’» πŸ‘¨β€πŸ’»

On this milestone πŸ—Ώ We have implemented the following :

Link to our kanban board
Link to our front-end repo
Link to our back-end repo

image

image

@Meltrust
Copy link

Hi,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that is not accesible:

image

Kindly, make it public and try again.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready πŸ™

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@tsheporamantso
Copy link
Owner Author

tsheporamantso commented Feb 23, 2024 via email

@Meltrust
Copy link

Hi,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

You can do it

Required Changes ♻️

  • According to the project requirements:

image

At the time of this review, these are the pointings:

  • 32
  • 22
  • 25

Please notice that one member (tsheporamantso) has a lot more points than the other 2 members.

The general rule is that "No team member can have more than 5 points than any other member".

Kindly, tweak your pointings so we can meet this particular requirement. πŸ‘

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Meltrust
Copy link

Wow, you did it πŸŽ‰

Brilliant

Thank you for implementing the changes requested by the previous reviewer πŸ’ͺ πŸ₯‡ γŠ—οΈ

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

To highlight

  • Pointings are now equalβœ”οΈ

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants