-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Capstone Kanban Board π¨βπ» π¨βπ» π¨βπ» #5
Comments
Hi, While you made a great effort in this project, unfortunately, I cannot proceed to review your code. Invalid Code Review RequestYou have submitted a project, that is not accesible: Kindly, make it public and try again. Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready π Cheers and Happy coding!πππ Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. Invalid Code Review Request does not count into the code reviews limit. |
Hi Miguel
Please accept my most sincere apology, I've attached the correct link.
Thank you
Gladwin Ramantso.
β¦________________________________
From: Miguel Tapia ***@***.***>
Sent: Friday, 23 February 2024 15:51
To: tsheporamantso/final-capstone-rails-api ***@***.***>
Cc: Gladwin Tshepo Ramantso ***@***.***>; Author ***@***.***>
Subject: Re: [tsheporamantso/final-capstone-rails-api] Final Capstone Kanban Board π¨βπ» π¨βπ» π¨βπ» (Issue #5)
Hi,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that is not accesible:
image.png (view on web)<https://github.com/tsheporamantso/final-capstone-rails-api/assets/57421823/523e6ca9-053b-4c52-b9cc-84f98d941aa9>
Kindly, make it public and try again.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready π
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
________________________________
Invalid Code Review Request does not count into the code reviews limit.
β
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2KUGREDTRKGOVO72URIWRLYVCNG7AVCNFSM6AAAAABDWX5IQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGM3DGNBQGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi, Good job so far! Required Changes β»οΈ
At the time of this review, these are the pointings:
Please notice that one member (tsheporamantso) has a lot more points than the other 2 members. The general rule is that "No team member can have more than 5 points than any other member". Kindly, tweak your pointings so we can meet this particular requirement. π Cheers and Happy coding!πππ Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Wow, you did it πThank you for implementing the changes requested by the previous reviewer πͺ π₯ γοΈWell done!Your project is complete! There is nothing else to say other than... it's time to merge it To highlight
Optional suggestionsEvery comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application. Cheers and Happy coding!πππ Feel free to leave any questions or comments in the PR thread if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Final Capstone Kanban Board π¨βπ» π¨βπ» π¨βπ»
On this milestone πΏ We have implemented the following :
Link to our kanban board
Link to our front-end repo
Link to our back-end repo
The text was updated successfully, but these errors were encountered: