libbpf: don't crash on object files with no symbol tables #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: 57f780f |
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=539951 expired. Closing PR. |
|
Master branch: 9e9fb76 |
tsipa
force-pushed
the
series/539951=>bpf
branch
from
5888c4e
to
ca28a3c
Compare
If libbpf encounters an ELF file that has been stripped of its symbol table, it will crash in bpf_object__add_programs() when trying to dereference the obj->efile.symbols pointer. Fix this by erroring out of bpf_object__elf_collect() if it is not able able to find the symbol table. v2: - Move check into bpf_object__elf_collect() and add nice error message Fixes: 6245947 ("libbpf: Allow gaps in BPF program sections to support overriden weak functions") Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
|
Master branch: 49ca615 |
tsipa
force-pushed
the
series/539951=>bpf
branch
from
ca28a3c
to
1b2303b
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=540531 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: don't crash on object files with no symbol tables
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=539951