Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variational dating does not allow a null mutation rate #263

Open
hyanwong opened this issue Jun 13, 2023 · 3 comments
Open

Variational dating does not allow a null mutation rate #263

hyanwong opened this issue Jun 13, 2023 · 3 comments

Comments

@hyanwong
Copy link
Member

For the other methods, we can ignore the mutations and simply estimate the branch lengths based on the prior. I'm not sure if this makes much sense for variational dating (and it might be poor for other dating too), but I simply note it here. If we don't allow it, we should explictly bomb out in variational_dates()

@nspope
Copy link
Contributor

nspope commented Jun 14, 2023

Hrm, I think it'd just reduce down to the iid prior if there's no mutation rate, because the Poisson likelihoods are undefined when $\mu = 0$ -- in which case, there's no approximation to compute (just the post-hoc correction to make branch lengths non-negative). So bombing out is the way to go.

@hyanwong
Copy link
Member Author

hyanwong commented Jun 14, 2023

Can we use this somehow to calculate a local prior from a global prior, though? Could we e.g. iterate while constraining the posterior of a parent to have a higher mean than its children, and run those messages around the graph?

@nspope
Copy link
Contributor

nspope commented Jun 14, 2023

Oh yes, I suppose even if the Poisson likelihood vanishes, there's still the parent > child indicator function. That'd need a separately designed EP algorithm to fit, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants