Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary unsafe #621

Closed
molpopgen opened this issue Apr 30, 2024 · 1 comment
Closed

unnecessary unsafe #621

molpopgen opened this issue Apr 30, 2024 · 1 comment

Comments

@molpopgen
Copy link
Member

TskBox::into_raw is marked unsafe.
This marking is not necessary.
The operation itself is safe.
Failure to manage the return value can cause a memory leak.
But memory leaks are not UB, and hence don't fall under unsafe.
@molpopgen
Copy link
Member Author

closed via #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen