don't run command in ui thread

it may hang the gui message loop
tsl0922 · Feb 6, 2024 · 58e5daf · 58e5daf
1 parent 7544fdb
commit 58e5daf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/menu.c b/src/menu.c
@@ -158,12 +158,10 @@ void show_menu(plugin_ctx *ctx, POINT *pt) {
     if (!PtInRect(&rc, *pt)) return;
 
     ClientToScreen(ctx->hwnd, pt);
-    mpv_command(ctx->mpv,
-                (const char *[]){"script-message", "menu-open", NULL});
+    mp_command_async("script-message menu-open");
     TrackPopupMenuEx(ctx->hmenu, TPM_LEFTALIGN | TPM_LEFTBUTTON, pt->x, pt->y,
                      ctx->hwnd, NULL);
-    mpv_command(ctx->mpv,
-                (const char *[]){"script-message", "menu-close", NULL});
+    mp_command_async("script-message menu-close");
 }
 
 // run mpv command stored in menu item data

diff --git a/src/plugin.c b/src/plugin.c
@@ -212,7 +212,7 @@ static void async_cmd_fn(void *data) {
     mpv_command_string(ctx->mpv, (const char *)data);
 }
 
-// run command on none-ui thread
+// run command in none-ui thread
 void mp_command_async(const char *args) {
     mp_dispatch_enqueue(ctx->dispatch, async_cmd_fn, (void *)args);
     mpv_wakeup(ctx->mpv);