memory corruption in tty_server_new

[PerBothner]

I found a memory corruption error in DomTerm. This was in code imported from ttyd, which appears to have the same bug: The cmd_len value does not include space for the final nul. Alternatively, you could:

ts->command = xmalloc(cmd_len+1);

The second part of the patch is optional - it just seems strange to use sprintf there. Is there some reason for it?

server-patch.txt

[tsl0922]

Thanks! This should be a bug, fixed by f533355, and removed the strange sprintf.

[PerBothner]

FWIW Setting the null terminator in line 118 is redundant, since stpcpy sets it, assuming cmd_argc > 0 . (It might still be reasonable to set it, for clarity.)