Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The last line cannot be seen sometimes #51

Closed
breezewish opened this issue Apr 4, 2017 · 4 comments
Closed

The last line cannot be seen sometimes #51

breezewish opened this issue Apr 4, 2017 · 4 comments
Labels
bug

Comments

@breezewish
Copy link

Seems that algorithm to calculate available lines have some bugs.
@tsl0922
Copy link
Owner

tsl0922 commented Apr 4, 2017

Can you provide some steps to reproduce this? or screenshots.

@breezewish
Copy link
Author

breezewish commented Apr 4, 2017 •
edited

demo

As you can see, in some scenarios users can only see half of the text in the last line

@tsl0922 tsl0922 added the bug label Apr 6, 2017
@tsl0922
Copy link
Owner

tsl0922 commented Jun 10, 2017 •
edited

Upstream: xtermjs/xterm.js#389

@tsl0922
Copy link
Owner

tsl0922 commented Sep 6, 2017

This may be caused by the terminal padding css, I've reverted it (3ac7a5e, waiting for xtermjs/xterm.js#946), it seems works. I'm going to close this issue.

@tsl0922 tsl0922 closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsl0922 @breezewish