Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Include test folder in wheels #154

Merged
merged 4 commits into from Oct 2, 2019

Conversation

rth
Copy link
Contributor

@rth rth commented Oct 2, 2019

Because the test folder didn't have an __init__.py file it was not considered to be a python module and was not included in wheels.

This adds it, which would make running tests on wheels easier in #150 with,

pytest --pyargs tslearn

this will run tests on the installed version of tslearn (installed from wheels or by other means).

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #154 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   93.86%   93.87%   +<.01%     
==========================================
  Files          22       22              
  Lines        2576     2579       +3     
==========================================
+ Hits         2418     2421       +3     
  Misses        158      158
Impacted Files Coverage Δ
tslearn/__init__.py 75% <100%> (ø) ⬆️
tslearn/tests/test_estimators.py 94.87% <100%> (ø) ⬆️
tslearn/tests/test_shapelets.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae9112...2e82ae2. Read the comment docs.

@rth
Copy link
Contributor Author

rth commented Oct 2, 2019

Also added a minor change to skip shapelets tests if keras or tensforflow are not installed,

python -m pytest tslearn/tests/test_shapelets.py -v
============================================================= test session starts =============================================================
platform linux -- Python 3.6.9, pytest-5.2.0, py-1.8.0, pluggy-0.13.0 -- /home/rth/src/tslearn/tslearn-env/bin/python
cachedir: .pytest_cache
rootdir: /home/rth/src/tslearn, inifile: setup.cfg
collected 2 items                                                                                                                             

tslearn/tests/test_shapelets.py::test_shapelets SKIPPED                                                                                 [ 50%]
tslearn/tests/test_shapelets.py::test_serializable_shapelets SKIPPED                                                                    [100%]

============================================================= 2 skipped in 0.77s ==============================================================

@rtavenar
Copy link
Member

rtavenar commented Oct 2, 2019

Can you also change tslearn version to 0.2.4 so that we use this version in our tests once merged ?

@rtavenar rtavenar merged commit 33b27e9 into tslearn-team:master Oct 2, 2019
@rth rth deleted the include-tests-in-wheels branch October 2, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants