-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images support #6
Conversation
Add images support for terminals that support it.
cool, my terminal (on linux doesn't support this) but it doesn't do anything weird, so I'll merge. |
@dominictarr Done. What do you think? |
that image doesn't display in github, I think you need to use an relative link, and check it into the repo. |
@dominictarr Done. |
you are missing screenshot.png |
@dominictarr That's not needed anymore. See: https://github.com/rafaelrinaldi/tslide/tree/feat/images |
okay, just one more thing: this currently loads files relative to the cwd (i think, can't test) but pretty sure that is what happens when you do Of course, the filenames should be relative to the md file, so it should be otherwise, you can't do |
@dominictarr Good catch. Fixed too. |
This PR adds image support to slides (thanks to iTerm).
Notes
TERM_PROGRAM
to figure it out)images
option which istrue
by default (let me know if it should befalse
by default)--no-images
Let me know if PR looks good. I can make any adjustments if needed.