Skip to content

Commit

Permalink
Merge pull request #17 from arjan/master
Browse files Browse the repository at this point in the history
Upgrade hackney to 0.11.1
  • Loading branch information
tsloughter committed Apr 8, 2014
2 parents 8ed3392 + 9471a61 commit 2be5c1b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rebar.config
Expand Up @@ -4,6 +4,6 @@
{deps_dir, ["deps"]}.

{deps, [
{hackney, "0.4.4", {git, "https://github.com/benoitc/hackney.git", {tag, "0.4.4"}}}
{hackney, "0.11.1", {git, "https://github.com/benoitc/hackney.git", {tag, "0.11.1"}}}

This comment has been minimized.

Copy link
@unbalancedparentheses

unbalancedparentheses Apr 10, 2014

Contributor

hackney uses idna. idna was updated and changed to an application. you should add to the readme that you need to start idna. check this commit:

https://github.com/tim/erlang-idna/pull/1/files?short_path=04c6e90&unchanged=collapsed#diff-86b16bb0d93bc234d5c411624be1025cR23

This comment has been minimized.

Copy link
@tsloughter

tsloughter Apr 10, 2014

Author Owner

I'm not sure what you mean, the readme doesn't list any deps you have to start since starting erlastic_search will start all the deps for you.

This comment has been minimized.

Copy link
@unbalancedparentheses

unbalancedparentheses Apr 10, 2014

Contributor

After the update of erlastic I get an error stating that idna was not started. I start idna and everything works fine.

This comment has been minimized.

Copy link
@tsloughter

tsloughter Apr 12, 2014

Author Owner

Oh, hm, I'll have to figure out why. It should not be up to the user to do separately.

This comment has been minimized.

Copy link
@tsloughter

tsloughter Apr 16, 2014

Author Owner

Oh, I didn't haven't his problem. Did you run with make shell?

,{jsx, "1.4.1", {git, "https://github.com/talentdeficit/jsx.git", {tag, "v1.4.1"}}}
]}.
2 changes: 1 addition & 1 deletion src/erlastic_search.app.src
Expand Up @@ -2,7 +2,7 @@
%% application.
{application, erlastic_search,
[{description, "An Erlang app for communicating with Elastic Search's rest interface."},
{vsn, "0.3.0"},
{vsn, "0.3.1"},
{modules, []},
{registered,[]},
{applications, [kernel
Expand Down
3 changes: 2 additions & 1 deletion src/erls_resource.erl
Expand Up @@ -70,7 +70,7 @@ do_request(#erls_params{host=Host, port=Port, timeout=Timeout, ctimeout=CTimeout
{ok, Status, _Headers, Client} when Status =:= 200
; Status =:= 201 ->
case hackney:body(Client) of
{ok, RespBody, _Client1} ->
{ok, RespBody} ->
{ok, jsx:decode(RespBody)};
{error, _Reason} = Error ->
Error
Expand Down Expand Up @@ -100,3 +100,4 @@ default_content_length(B, H) ->
make_body(Body, Headers, Options) ->
{default_content_length(Body, Headers), Options, Body}.


0 comments on commit 2be5c1b

Please sign in to comment.