Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VirtualKey #246

Merged
merged 10 commits into from
Aug 28, 2017
Merged

Implement VirtualKey #246

merged 10 commits into from
Aug 28, 2017

Conversation

rexim
Copy link
Member

@rexim rexim commented Aug 26, 2017

Close #245

@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

Merging #246 into master will increase coverage by 8.42%.
The diff coverage is 64.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   29.92%   38.35%   +8.42%     
==========================================
  Files          23       24       +1     
  Lines         999     1043      +44     
==========================================
+ Hits          299      400     +101     
+ Misses        700      643      -57
Impacted Files Coverage Δ
src/main.rs 1.2% <ø> (ø) ⬆️
src/screen/keyboard_layout_screen.rs 0% <ø> (ø) ⬆️
src/screen/looper_screen.rs 0% <ø> (ø) ⬆️
src/config/config_device_info.rs 0% <0%> (ø) ⬆️
src/fundamental/option.rs 0% <0%> (ø)
src/config/config.rs 30.3% <100%> (+30.3%) ⬆️
src/ui/virtual_key.rs 65.51% <45.45%> (+65.51%) ⬆️
src/ui/virtual_keyboard.rs 80.89% <75.55%> (+80.89%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3283de...23380d0. Read the comment docs.

@rexim rexim mentioned this pull request Aug 28, 2017
@rexim rexim merged commit 6e8ce28 into master Aug 28, 2017
@rexim rexim deleted the 245-virtual-key branch August 28, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants