This repository has been archived by the owner on Nov 11, 2021. It is now read-only.
Change the openat macro to use the syscall intrinsic for 4 argument syscalls #141
Open
mjz19910
wants to merge
165
commits into
tsoding:master
Choose a base branch
from
mjz19910:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b38fb3.
The strategy is based on check all of the possible execution paths
We've got memory blocks
Change the syscall intrinsic the openat macro uses to the 4 argument syscall intrinsic. When I was refactoring the porth.porth program to actually write output to a file, I encountered the inability to set the permission mask when `openat`ing the out.asm file.
a different program. Stuff I already did... Porth, open and write the asm to a file. Stuff I will work on... Python, want to figure out constant folding optimization next
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was programming the porth.porth program to eventually write the compiled asm to a file.
I encountered a requirement to set the permission mask when using the
openat
syscall to open a output file for writing.When I could only pass 3 of the 4 arguments, I ended up with a file I didn't have write permission to open again. The next time I attempted to run the compiled porth compiler, I was denied permission to open the output file.